Moti Asayag has posted comments on this change.
Change subject: code: change data members to start with a lowercase letter
......................................................................
Patch Set 1:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
Line 36:
Line 37: @Override
Line 38: protected void executeVmCommand() {
Line 39: super.executeVmCommand();
Line 40: getParameters().originalTemplate = getVm().getVmtGuid();
The proper solution should be reducing its visibility to private and expose a
proper getter for it.
Line 41: getVm().setVmtGuid(VmTemplateHandler.BlankVmTemplateId);
Line 42:
getVm().getStaticData().setQuotaId(getParameters().getVmStaticData().getQuotaId());
Line 43:
DbFacade.getInstance().getVmStaticDao().update(getVm().getStaticData());
Line 44: // if there are no tasks, we can end the command right away.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
Line 35:
Line 36: @Override
Line 37: protected void executeVmCommand() {
Line 38: Set<Guid> mImagesToBeRemoved = new HashSet<Guid>();
Line 39: List<DiskImage> images = getParameters().images;
same here.
Line 40: if (images == null) {
Line 41: images =
Line 42:
ImagesHandler.filterImageDisks(DbFacade.getInstance().getDiskDao().getAllForVm(getVmId()),
Line 43: true,
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmFromTemplateParameters.java
Line 9:
Line 10: public class AddVmFromTemplateParameters extends
VmManagementParametersBase {
Line 11: private static final long serialVersionUID = -3400982291165788716L;
Line 12:
Line 13: public Guid originalTemplate;
this property should be private, exposed via getter and setter.
Line 14:
Line 15: public AddVmFromTemplateParameters(VmStatic vmStatic,
HashMap<Guid, DiskImage> diskInfoDestinationMap,
Line 16: Guid storageDomainId) {
Line 17: super(vmStatic);
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveAllVmImagesParameters.java
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5:
Line 6: public class RemoveAllVmImagesParameters extends
VmOperationParameterBase implements java.io.Serializable {
Line 7: private static final long serialVersionUID = 7211692656127711421L;
Line 8: public java.util.List<DiskImage> images;
this one as well.
Line 9:
Line 10: public RemoveAllVmImagesParameters(Guid vmId,
java.util.List<DiskImage> images) {
Line 11: super(vmId);
Line 12: this.images = images;
--
To view, visit http://gerrit.ovirt.org/22239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28d10aead22f2753ab5b98b9abc4e71d860f087
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
