Vojtech Szocs has posted comments on this change.
Change subject: webadmin : Hide virt fields in the host->general sub-tab in
Gluster mode
......................................................................
Patch Set 6:
Hm, the new FormBuilder.addFormItem method modifies FormItem post its creation
which implies reduced immutability of FormItem from design perspective.
I like the idea of computing "nextEmptyRowForColumn" though, maybe we can do
this instead (without modifying FormItem class):
int column = 0; // example
formBuilder.addFormItem(new FormItem("Test", testValueWidget,
formBuilder.getNextRow(column), column));
What do you think?
--
To view, visit http://gerrit.ovirt.org/22220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I770547907c681a4648999c9d0d3d3ff7aba93971
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
