Kanagaraj M has posted comments on this change.
Change subject: webadmin,userportal: Improve TextBoxLabelBase
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
....................................................
Commit Message
Line 32: using Renderer<? super T> instead of just Renderer<T>
Line 33: at runtime.
Line 34:
Line 35: (Makes me wonder why GWT ValueBoxBase doesn't work
Line 36: with Renderer<? super T> just like GWT ValueLabel.)
I can't imagine why Parser has to be Covariant and Renderer has to be
Contravariant.
Does it mean, renderer of super-type can render sub-types?
Line 37:
Line 38: Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/BooleanTextBoxLabel.java
Line 10:
Line 11: public BooleanTextBoxLabel(String trueText, String falseText) {
Line 12: super(new BooleanRenderer(trueText, falseText));
Line 13: }
Line 14:
this file can be excluded
--
To view, visit http://gerrit.ovirt.org/22236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie691685ec6e9e1830da1457a0747901ba833be5d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
