Yair Zaslavsky has posted comments on this change.
Change subject: WIP core+ui+restapi: putting the session locale in the
SessionDataContainer
......................................................................
Patch Set 2:
(1 comment)
I tend to agree with Alon here -
Any reason not to send the locale on each request?
....................................................
File
backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/Challenger.java
Line 187: Principal principal = scheme.decode(headers);
Line 188: String engineSessionId =
SessionUtils.generateEngineSessionId();
Line 189: String localeString = null;
Line 190: List<String> locale =
SessionUtils.getHeaderField(headers, SessionUtils.SESSION_LOCALE);
Line 191: if (locale != null && locale.size() != 0) {
What exists at other elements in the list?
Line 192: localeString = locale.get(0);
Line 193: }
Line 194: if (validator == null || validator.validate(principal,
engineSessionId, localeString)) {
Line 195: successful = true;
--
To view, visit http://gerrit.ovirt.org/21016
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbe5cd33d075d3f10ffc2d1a9c62c310bf28ebc4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
