Arik Hadas has posted comments on this change. Change subject: core: Decrement pending memory/cpus after finished migration ......................................................................
Patch Set 4: (2 comments) .................................................... Commit Message Line 6: Line 7: core: Decrement pending memory/cpus after finished migration Line 8: Line 9: The engine leaved pending memory in DB after successfull migrations Line 10: and this caused hosts to reject more VMs after some time. Sorry, my bad.. it is called from RunVmCommandBase#rerun so it is covered Line 11: Line 12: Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Line 13: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1039900 .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java Line 381: try { Line 382: super.runningSucceded(); Line 383: } Line 384: finally { Line 385: // Decrement the pending counters please also explain that it is not decremented by onPowerringUp, as it should, because this method is not called on successful migration (bug..). we'll probably forget about this issue in few weeks and wonder why it is decremented twice.. Line 386: decreasePendingVms(getVdsDestinationId()); Line 387: Line 388: freeLock(); Line 389: } -- To view, visit http://gerrit.ovirt.org/22233 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ce2756d17a7bc3b0a5be56a44936a70aa227c5 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
