Yair Zaslavsky has posted comments on this change.
Change subject: gluster: add force support to add-bricks
......................................................................
Patch Set 13:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
Line 256:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_BRICKS_REQUIRED);
Line 257: return false;
Line 258: }
Line 259:
Line 260: if
(!GlusterFeatureSupported.glusterForceCreateVolumeSupported(getVdsGroup().getcompatibility_version())
Can this check (which already appeared in one command) be extracted so we will
not need to duplicate this code?
I would recommend you to consider using the "validator" pattern we use at bll ,
for example - StoragePoolValidator.
Line 261: && getParameters().isForce()) {
Line 262:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_GLUSTER_VOLUME_ADD_BRICK_FORCE_NOT_SUPPORTED);
Line 263: return false;
Line 264: }
--
To view, visit http://gerrit.ovirt.org/21403
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
