Allon Mureinik has posted comments on this change.
Change subject: core: Fix FB on AddExistingFileStorageDomain
......................................................................
Patch Set 1:
@Maor, this is not correct.
runVdsCommand we use is implemented as following:
@Override
public VDSReturnValue RunVdsCommand(VDSCommandType commandType,
VDSParametersBase parameters) {
return
VdsHandler.handleVdsResult(getResourceManager().runVdsCommand(commandType,
parameters));
}
if there is no such command you'd pass null to handleVdsResult, which will
crash with an NPE.
--
To view, visit http://gerrit.ovirt.org/22331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8c5a11ef872cac6aeebfa18bf28757fb4a8b26c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
