Shahar Havivi has posted comments on this change.
Change subject: new feature: Vm Payload
......................................................................
Patch Set 12: (16 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 315:
getParameters().getVmStaticData().getVmPayload().setContent(Base64.encodeBase64String(
this is not sysprep feature this is payload for vm
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java
Line 23: VmDeviceDAO dao = DbFacade.getInstance().getVmDeviceDAO();
Done
Line 24: List<VmDevice> disks = new
ArrayList(dao.getVmDeviceByVmIdAndType(getParameters().getId(),
VmDeviceType.DISK.getName()));
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 96: VmDeviceDAO dao = DbFacade.getInstance().getVmDeviceDAO();
Done
Line 100: List<VmDevice> disks = new
ArrayList(dao.getVmDeviceByVmIdAndType(getVmId(), VmDeviceType.DISK.getName()));
Done
Line 110: List devs = new ArrayList<VmDeviceId>();
Done
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 526: Integer lengthInKb = 2 * Config.<Integer>
GetValue(ConfigValues.PayloadSize) / 1024;
Done
I think we need to change the number 2 to const...
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
Line 11: public class VmPayload implements Serializable {
what is that good for and how do I generate the number?
Line 15:
Done
Line 18: private static String SpecParamsParamSeparator = ",";
Done
Line 44: this.content = files.get(key).toString();
no, next version will support few payloads
Line 49: return specParams.containsKey(SpecParamsPayload);
Done
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1111: @TypeConverterAttribute(Integer.class)
Done
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 113: vm.getVmPayload().getSpecParams(),
Done
Line 180: vm.getVmPayload().getSpecParams(),
Done
....................................................
Commit Message
Line 12: Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
this is upstrem...
--
To view, visit http://gerrit.ovirt.org/3243
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c2820acfa8ec0f736e5fe0ce192e84df0915f12
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
