Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: adding externalize check to the frontend checkstyle
......................................................................
webadmin: adding externalize check to the frontend checkstyle
no bz
1. Separating build-tools into two packages-
* checksyles- for checkstyle xml files.
* ovirt-checkstyle-extension- for adding to new (not built-in)
checkstyle checks.
2. Add to the ckechstyle.xml new check- NlsCheck.
This check fails if there is a non externalized string in a java file and
there is no //$NON-NLS-N$ comment to mark that it is ok that the string
is not externalized.
To understand more about the need of this check
see http://gerrit.ovirt.org/#change,3612
Important- The NlsCheck wouldn't run by default. If you want
this check to run on a specific project you have to add
<propertyExpansion>runNlsCheck=false</propertyExpansion>
to the configuration of the checkstyle in the project's pom.
Signed-off-by: Alona Kaplan <[email protected]>
Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784
---
R build-tools-root/checkstyles/pom.xml
A build-tools-root/checkstyles/src/main/resources/checkstyle.xml
A build-tools-root/ovirt-checkstyle-extension/pom.xml
A build-tools-root/ovirt-checkstyle-extension/src/main/java/NlsCheck.java
A build-tools-root/pom.xml
D build-tools/src/main/resources/checkstyle.xml
M frontend/webadmin/modules/frontend/pom.xml
M frontend/webadmin/modules/gwt-common/pom.xml
M frontend/webadmin/modules/uicommonweb/pom.xml
M frontend/webadmin/modules/userportal-gwtp/pom.xml
M frontend/webadmin/modules/webadmin/pom.xml
M pom.xml
12 files changed, 235 insertions(+), 40 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie23035701398158b70b61c1c85a7f6eb40770784
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
