Allon Mureinik has posted comments on this change.
Change subject: core: [Fix] Add host hotplug support checks
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
+1 from me, except for some nits (see inline).
Roy - final decision up to you.
Cherryn - any input on the error messages?
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
Line 66:
Line 67: @ClassRule
Line 68: public static final MockConfigRule mcr = new MockConfigRule(
Line 69: mockConfig(ConfigValues.HotPlugEnabled, "3.1", true),
Line 70: mockConfig(ConfigValues.HotPlugDiskSnapshotSupported,
"3.1", true));
I'd use Version.v3_1.getValue() instead of a "3.1" literal.
Line 71:
Line 72: @Mock
Line 73: private VmDAO vmDAO;
Line 74: @Mock
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 858: ILLEAGAL_USER_PROVIDED=Illegal user supplied
Line 859: USER_CANNOT_BE_ADDED_TO_VM=User cannot be added to VM
Line 860: USER_CANNOT_BE_ADDED_TO_VM_POOL=User cannot be added to VM-Pool
Line 861: ACTION_TYPE_FAILED_DETECTED_PINNED_VMS=Cannot ${action} ${type}. The
following VMs are set to run specifically only on this Host: ${VmNames}.\nIn
order to ${action} ${type}, you need to remove the association between the VMs
and the Host (Using Edit VM properties).
Line 862: HOT_PLUG_IS_NOT_SUPPORTED=Activate/Deactivate while VM is running, is
only supported for Clusters of version 3.1 and above.
I'd remove the 3.1 literal from here.
Line 863: HOT_PLUG_DISK_SNAPSHOT_IS_NOT_SUPPORTED=Cannot ${action} ${type}.
Activation/Deactivation of Disk Snapshot is not supported for clusters of
version ${clusterVersion}.
Line 864: UNLINKING_IS_NOT_SUPPORTED=Cannot ${action} ${type}. Link state is
set to 'Down' on the virtual machine's interface, this is not supported for
clusters of version ${clusterVersion}.
Line 865: NULL_NETWORK_IS_NOT_SUPPORTED=Cannot ${action} ${type}. There is no
network on the virtual machine's interface, this is not supported for clusters
of version ${clusterVersion}.
Line 866: ACTION_TYPE_FAILED_NETWORK_QOS_IS_NOT_SUPPORTED=Cannot ${action}
${type}. There is Network QoS on the profile, this is not supported for
clusters of version ${clusterVersion}.
--
To view, visit http://gerrit.ovirt.org/21266
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c8409c0de4ff1c959d27b54e793a31654326c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: liron aravot <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
