Alissa Bonas has uploaded a new change for review. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ......................................................................
frontend: ignore in findbugs EventArgs unconfirmed cast errors Ignore in findbugs errors related to casting EventArgs. The casting is safe in this case, and a future refactoring will make findbug warning resolved in any case.(RFE #1034844) This is patch #10 following http://gerrit.ovirt.org/#/c/22230/ Change-Id: I1722507982e53f91dfd1f932f9b463cb5e72c2c7 Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 3 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/22394/1 diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml b/frontend/webadmin/modules/gwt-common/exclude-filters.xml index d9309f1..6882968 100644 --- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml +++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml @@ -193,33 +193,18 @@ </Match> <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$18" /> + <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$17" /> <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$21" /> + <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$20" /> <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$22" /> + <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$23" /> <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$24" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$25" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.AbstractVmPopupWidget$26" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> <Match> @@ -288,7 +273,7 @@ </Match> <Match> - <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmRunOncePopupWidget$14" /> + <Class name="org.ovirt.engine.ui.common.widget.uicommon.popup.vm.VmRunOncePopupWidget$13" /> <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> diff --git a/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml index 5737cb3..b36fe67 100644 --- a/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml +++ b/frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml @@ -64,5 +64,10 @@ <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> + <Match> + <Class name="org.ovirt.engine.ui.userportal.uicommon.UserPortalConfigurator" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + </FindBugsFilter> diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml b/frontend/webadmin/modules/webadmin/exclude-filters.xml index df872a1..3db1cbc 100644 --- a/frontend/webadmin/modules/webadmin/exclude-filters.xml +++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml @@ -357,7 +357,7 @@ </Match> <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.profile.VnicProfilePopupView$4" /> + <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.profile.VnicProfilePopupView$3" /> <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> @@ -391,4 +391,14 @@ <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.host.HostSetupNetworksPopupView$2" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.uicommon.WebAdminConfigurator" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/22394 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1722507982e53f91dfd1f932f9b463cb5e72c2c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
