Lior Vernia has posted comments on this change.
Change subject: core, engine: New validations for host entrance in clusters
......................................................................
Patch Set 2:
(4 comments)
The members added to the localized enum files look fine syntactically, but I
think there might be a case to split one of the non-operational reasons into
two different reasons, see comments.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NonOperationalReason.java
Line 5:
Line 6: public enum NonOperationalReason {
Line 7:
Line 8: NONE(0),
Line 9: GENERAL(1),
See comments in LocalizedEnums.properties, this could potentially be removed
(or replaced by CPU_TYPE_UNSUPPORTED to keep the enum numbering).
Line 10: CPU_TYPE_INCOMPATIBLE_WITH_CLUSTER(2),
Line 11: STORAGE_DOMAIN_UNREACHABLE(3),
Line 12: NETWORK_UNREACHABLE(4),
Line 13: VERSION_INCOMPATIBLE_WITH_CLUSTER(5),
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
Line 6:
Line 7: String NonOperationalReason___NONE();
Line 8:
Line 9: String NonOperationalReason___GENERAL();
Line 10:
See comments in LocalizedEnums.properties. If there's no need to separate
CPU_TYPE_UNSUPPORTED into two different messages, I think this can be removed.
Line 11: String NonOperationalReason___CPU_TYPE_INCOMPATIBLE_WITH_CLUSTER();
Line 12:
Line 13: String NonOperationalReason___STORAGE_DOMAIN_UNREACHABLE();
Line 14:
....................................................
File
frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
Line 1: NonOperationalReason___NONE=Host is Operational.
Line 2: NonOperationalReason___GENERAL=Unknown reason.
Line 3: NonOperationalReason___CPU_TYPE_INCOMPATIBLE_WITH_CLUSTER=Host CPU type
is not compatible with Cluster Properties.
Read the next comment first. If there's no need to separate the two messages,
then as far as I can tell this can be removed.
Line 4: NonOperationalReason___STORAGE_DOMAIN_UNREACHABLE=Host failed to attach
one of the Storage Domains attached to it.
Line 5: NonOperationalReason___NETWORK_UNREACHABLE=One of the Logical Networks
defined for this Cluster is Unreachable by the Host.
Line 6: NonOperationalReason___VM_NETWORK_IS_BRIDGELESS=One of the host's
networks is configured as a non-VM network while its Logical Network definition
specifies it is a VM network. Sync network.
Line 7: NonOperationalReason___VERSION_INCOMPATIBLE_WITH_CLUSTER=Host's
Compatibility Version doesn't match the Cluster's Compatibility Version.
Line 13: NonOperationalReason___GLUSTER_HOST_UUID_ALREADY_EXISTS=Gluster UUID
already exists.
Line 14: NonOperationalReason___EMULATED_MACHINES_INCOMPATIBLE_WITH_CLUSTER=The
Host emulated machine flags doesn't match one of the cluster emulated machines.
Line 15: NonOperationalReason___UNTRUSTED=Host is untrusted.
Line 16: NonOperationalReason___UNINITIALIZED=Host is uninitialized as it is
not attested yet.
Line 17: NonOperationalReason___CPU_TYPE_UNSUPPORTED=Host CPU type is not
supported in this cluster compatibility version or is not supported at all.
I'm not sure I understand what it means that a CPU type is unsupported at all
(as opposed to it not being supported just in a specific cluster compatibility
version). This seems new, could you explain when that happens? And why it has
only become possible now with PPC support?
If it is indeed something that can happen, I think it's a different story from
having a CPU type that's not supported in a specific cluster, and merits its
own NonOperationalReason.
Line 18: NonOperationalReason___ARCHITECTURE_INCOMPATIBLE_WITH_CLUSTER=Host's
architecture doesn't match the Cluster's architecture.
Line 19: UsbPolicy___ENABLED_LEGACY=Legacy
Line 20: UsbPolicy___DISABLED=Disabled
Line 21: UsbPolicy___ENABLED_NATIVE=Native
--
To view, visit http://gerrit.ovirt.org/22029
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia617481b102b3d5383a0d38da03e10ff95afefe2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
