Roy Golan has posted comments on this change.
Change subject: core: Architecture related checks for VMs and templates
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 600:
Line 601: ACTION_TYPE_FAILED_ILLEGAL_NUM_OF_MONITORS=Cannot ${action} ${type}.
Illegal number of monitors is provided, max allowed number of monitors is 1 for
VNC and the max number in the ValidNumOfMonitors configuration variable for
SPICE.
Line 602: ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_OS_TYPE=Cannot ${action}
${type}. Cannot set single display device to non Linux operating system.
Line 603: ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_DISPLAY_TYPE=Cannot
${action} ${type}. Cannot set single display device via VNC display.
Line 604:
ACTION_TYPE_FAILED_ILLEGAL_OS_TYPE_IS_NOT_SUPPORTED_BY_ARCHITECTURE_TYPE=Cannot
${action} ${type}. Selected operating system is not supported by the
architecture.
this is redundant I think. you can use
ACTION_TYPE_FAILED_VM_CANNOT_IMPORT_VM_ARCHITECTURE_NOT_SUPPORTED_BY_CLUSTER
but change its name to be more general
Line 605: ACTION_TYPE_FAILED_ILLEGAL_SINGLE_DEVICE_INCOMPATIBLE_VERSION=Cannot
${action} ${type}. Cluster does not support Single Qxl Pci devices.
Line 606: ACTION_TYPE_FAILED_ILLEGAL_DOMAIN_NAME=Cannot ${action} ${type}.
Illegal Domain name: ${Domain}. Domain name has unsupported special character
${Char}.
Line 607: ACTION_TYPE_FAILED_ILLEGAL_ARCHITECTURE_TYPE_INCOMPATIBLE=Cannot
${action} ${type}. Architecture does not match the expected value.
Line 608: ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION=Cannot
decrease data center compatibility version.
--
To view, visit http://gerrit.ovirt.org/18227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia877dd2d13525de6693883e43d0ca786f77f9310
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
