Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: Allow static IP on the host
......................................................................
Patch Set 1: Verified+1
(2 comments)
....................................................
File src/plugins/ovirt-hosted-engine-setup/network/bridge.py
Line 217: 'bridged=True',
Line 218: 'ONBOOT=yes',
Line 219: ]
Line 220: boot_proto = caps['cfg']['BOOTPROTO']
Line 221: cmd += ['bootproto=%s' % boot_proto]
Tried both BOOTPROTO and bootproto, there was no difference. Danken told me to
use bootproto.
Line 222: if boot_proto == 'dhcp':
Line 223: cmd += [
Line 224: 'blockingdhcp=true',
Line 225: ]
Line 222: if boot_proto == 'dhcp':
Line 223: cmd += [
Line 224: 'blockingdhcp=true',
Line 225: ]
Line 226: elif boot_proto in ('static', 'none'):
I've seen 'static', doc says 'anything but dhcp or bootp'. Perhaps we want to
add above bootp, change the 'elif' here to 'else' and drop the 'else' below.
Line 227: cmd += [
Line 228: 'ipaddr=%s' % caps['addr'],
Line 229: 'netmask=%s' % caps['netmask'],
Line 230: 'gateway=%s' % caps['cfg']['GATEWAY'],
--
To view, visit http://gerrit.ovirt.org/22399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I108c2202ebed0e90a7d06cfdef1bce8154cfd3fb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
