Sahina Bose has uploaded a new change for review. Change subject: engine: Fixed redundant null check find bug error ......................................................................
engine: Fixed redundant null check find bug error Redundant nullcheck of glusterServer, fixed Change-Id: I9652c52e2886a4c225b5a79985f18f7f372dd4e4 Signed-off-by: Sahina Bose <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/05/22405/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java index d6e5cae..9712ddb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java @@ -449,8 +449,7 @@ private boolean hostUuidExists(Guid addedServerUuid) { GlusterServerDao glusterServerDao = DbFacade.getInstance().getGlusterServerDao(); GlusterServer glusterServer = glusterServerDao.getByGlusterServerUuid(addedServerUuid); - if ((glusterServer == null) || - (glusterServer != null && glusterServer.getId().equals(getVds().getId()))) { + if (glusterServer == null || glusterServer.getId().equals(getVds().getId())) { return false; } return true; -- To view, visit http://gerrit.ovirt.org/22405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9652c52e2886a4c225b5a79985f18f7f372dd4e4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
