Liron Ar has posted comments on this change.
Change subject: core: Move VDS to Maintenance only if StopSPM is successful
......................................................................
Patch Set 8: Code-Review+1
(3 comments)
generally looks fine, minor comments.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVdsStatusVDSCommandParameters.java
Line 28: public VDSStatus getStatus() {
Line 29: return _status;
Line 30: }
Line 31:
Line 32: public SetVdsStatusVDSCommandParameters() {
now in some of the ctors the assigment is there and for some it's not, just
remove it please.
Line 33: _status = VDSStatus.Unassigned;
Line 34: nonOperationalReason = NonOperationalReason.NONE;
Line 35: }
Line 36:
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 706: DISK_ALIGNMENT_SCAN_START=Starting alignment scan of disk
'${DiskAlias}'.
Line 707: DISK_ALIGNMENT_SCAN_FAILURE=Alignment scan of disk '${DiskAlias}'
failed.
Line 708: DISK_ALIGNMENT_SCAN_SUCCESS=Alignment scan of disk '${DiskAlias}' is
complete.
Line 709: VM_MEMORY_NOT_IN_RECOMMENDED_RANGE=VM ${VmName} was configured with
${VmMemInMb}mb of memory while the recommended value range is ${VmMinMemInMb}mb
- ${VmMaxMemInMb}mb
Line 710: VDS_STATUS_CHANGE_FAILED_DUE_TO_STOP_SPM_FAILURE=Failed to change
status of host '${VdsName}' due to failure to stop the spm.
failure/a failure
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java
Line 42: }
Line 43: } catch (Exception e) {
Line 44: performSpmStop = false;
Line 45: log.infoFormat("SpmStopVDSCommand::Could not get
tasks on vds {0} stopping SPM",
Line 46: getVds().getName());
1. the log isn't correct now.
2. please verify that this change won't cause to any side effects :)
Line 47: }
Line 48: if (performSpmStop) {
Line 49: log.infoFormat("SpmStopVDSCommand::Stopping SPM on
vds {0}, pool id {1}", getVds().getName(),
Line 50: getParameters().getStoragePoolId());
--
To view, visit http://gerrit.ovirt.org/21231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c58f9a9629d2e7a496f02c4dececeb842d44543
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
