Omer Frenkel has posted comments on this change.
Change subject: engine: Log detection of orphan gluster tasks
......................................................................
Patch Set 3:
(1 comment)
looks ok, minor comment/suggestion
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterTasksSyncJob.java
Line 347: values.put(GlusterConstants.CLUSTER, vol == null ? ""
:vol.getVdsGroupName());
Line 348: values.put(GlusterConstants.VOLUME, vol == null ? ""
: vol.getName());
Line 349: values.put(GlusterConstants.JOB_STATUS,
JobExecutionStatus.UNKNOWN.toString());
Line 350: values.put(GlusterConstants.JOB_INFO, " ");
Line 351:
step.setDescription(ExecutionMessageDirector.resolveStepMessage(step.getStepType(),
values));
looks like you could create the values map once and re-use it for all steps,
assuming resolveStepMessage method doesn't change the map. what do you think?
Line 352: getGlusterTaskUtils().endStepJob(step);
Line 353: if (vol != null) {
Line 354: logTaskStoppedFromCLI(step, vol);
Line 355: }
--
To view, visit http://gerrit.ovirt.org/22364
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9cc4658dc4ed5700ce93463f4480d65e7d71c12
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
