Ori Liel has posted comments on this change.
Change subject: restapi: 'concurrent' Not Displayed For Primary PM Agent
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java
Line 488: if (!StringUtils.isEmpty(entity.getPmSecondaryIp())) {
Line 489: boolean concurrent = entity.isPmSecondaryConcurrent();
Line 490: // When a second agent exists, 'concurrent' field is
relevant for both agents, so here we
Line 491: // set it retroactively in the first agent.
Line 492:
model.getAgents().getAgents().get(0).setConcurrent(concurrent);
You suggest a solution that will be more generic and scale to more than two
agents, and I completely agree with this approach. However, if we ever will
need to scale to more than two agents (a slim chance according to Eli, by the
way) then we would want to support more complex behaviours such as, for example:
1) Try Using agent_A
2) If A doesn't work, use 'agent_B' & 'agent_C' concurrently.
In such a scenario, we wouldn't want to set 'concurrent=true' for all agents,
if 'concurrent=true' has been found in one agent, as it would be legal for one
agent to have concurrent=false and other agents to have concurrent=true
Line 493: agent = new Agent();
Line 494: agent.setType(entity.getPmSecondaryType());
Line 495: agent.setAddress(entity.getPmSecondaryIp());
Line 496: agent.setUsername(entity.getPmSecondaryUser());
--
To view, visit http://gerrit.ovirt.org/21781
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If0882d1db6c13b24c767e0cb40b9b797e8b61860
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
