Arik Hadas has posted comments on this change.
Change subject: backend: Avoid IsoPrefix command when no iso attached
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 374:
Line 375: public static String cdPathWindowsToLinux(String windowsPath,
Guid storagePoolId, Guid vdsId) {
Line 376: if (StringUtils.isEmpty(windowsPath)) {
Line 377: return windowsPath; // empty string is used for 'eject'
Line 378: }
The tests should protect us from breaking the code, not to have weird stuff in
the code in order to prevent breaking the tests.. that's ok to modify tests
when the code is changed. The right way imo is to change the test to call
cdPathWindowsToLinux(String, Guid, Guid) method and mock the invocation of
IsoPrefix command
Line 379: return cdPathWindowsToLinux(windowsPath, (String)
Backend.getInstance()
Line 380: .getResourceManager()
Line 381: .RunVdsCommand(VDSCommandType.IsoPrefix, new
VdsAndPoolIDVDSParametersBase(vdsId, storagePoolId))
Line 382: .getReturnValue());
--
To view, visit http://gerrit.ovirt.org/22257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If83986270400fdefd31aa01a1736de350ab6a5ec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
