Roy Golan has posted comments on this change.
Change subject: core, engine: sPAPR SCSI on PPC64 VMs
......................................................................
Patch Set 3:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java
Line 5:
Line 6: public enum DiskInterface {
Line 7:
Line 8: IDE("ide", "ide"),
Line 9: VirtIO_SCSI("virtio-scsi", "scsi"),
digging further in the code I don't see any use of the mapping using the name.
we should stick to DiskInterface(interfaceName) and remove the forValue
Line 10: VirtIO("virtio", "virtio"),
Line 11: SPAPR_VSCSI("spapr-vscsi", "scsi");
Line 12:
Line 13: private String name;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/architecture/AssignSCSIAddress.java
Line 34: // Since there is a SCSI controller in the first index of
every ppc64 VM
Line 35: // the VirtIO-SCSI controller is assigned to the index 1.
Line 36: // This function sets the disk to the correct address
Line 37:
Line 38: if (diskInterface.equals(DiskInterface.VirtIO_SCSI))
==
Line 39: {
Line 40: SCSIAddressingUtils.dynamicAddressing(device,
maxUsedLunByController, 1);
Line 41: } else if (diskInterface.equals(DiskInterface.SPAPR_VSCSI)) {
Line 42: SCSIAddressingUtils.dynamicAddressing(device,
maxUsedLunByController, 0);
Line 35: // the VirtIO-SCSI controller is assigned to the index 1.
Line 36: // This function sets the disk to the correct address
Line 37:
Line 38: if (diskInterface.equals(DiskInterface.VirtIO_SCSI))
Line 39: {
formatting of block
Line 40: SCSIAddressingUtils.dynamicAddressing(device,
maxUsedLunByController, 1);
Line 41: } else if (diskInterface.equals(DiskInterface.SPAPR_VSCSI)) {
Line 42: SCSIAddressingUtils.dynamicAddressing(device,
maxUsedLunByController, 0);
Line 43: }
--
To view, visit http://gerrit.ovirt.org/18622
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4fefa225cb44f0e09a7a056e07b8393dda6819b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
