Sahina Bose has posted comments on this change.
Change subject: gluster: Added additional can do action check
......................................................................
Patch Set 11:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/gluster/GlusterBrickValidator.java
Line 147: break;
Line 148: }
Line 149:
Line 150: if (!found) {
Line 151: return false;
this should be outside the loop? Otherwise it will only check for the first
brick in the list
Line 152: }
Line 153: }
Line 154: }
Line 155:
Line 166: builder.append(brick.getQualifiedName());
Line 167: builder.append(", ");
Line 168: }
Line 169:
Line 170: return builder.substring(0, builder.length() - 2).toString();
Are we sure that bricksForTask will never be empty? otherwise builder.length -2
would cause error
Line 171: }
--
To view, visit http://gerrit.ovirt.org/22353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f5d3b48985552aa5f74178008beb39ee7a06f9
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
