Kanagaraj M has posted comments on this change.
Change subject: engine: Gluster peer probe and status on same server
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 419: if (newUpServer == null) {
Line 420: //there's no other up server. so there's
no issue with peer status results
Line 421: return true;
Line 422: }
Line 423: List<GlusterServerInfo> newGlusterServers =
getGlusterPeers(newUpServer.getId());
We are calling 'gluster peer status' on a different up-server immediately
followed the 'peer probe'. I think we should give some delay in between,
otherwise most of the time s the host might be moved to non-operational.
Also its better to check status of the peer as well.
Line 424: if (!hostExists(newGlusterServers, getVds()))
{
Line 425: // try once more?
Line 426: customLogValues.put("Command", "gluster
peer status " + getVds().getHostName());
Line 427:
setNonOperational(NonOperationalReason.GLUSTER_COMMAND_FAILED, customLogValues);
--
To view, visit http://gerrit.ovirt.org/22448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
