Adam Litke has posted comments on this change.
Change subject: engine: Track the time a VM was last stopped
......................................................................
Patch Set 1:
(1 comment)
Juan, thanks for the review. I will take a look at enabling the DAO tests.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 749: tempVar.setVmHost("");
Line 750: tempVar.setVmIp("");
Line 751: tempVar.setVmFQDN("");
Line 752:
tempVar.setDisplayType(getParameters().getVmStaticData().getDefaultDisplayType());
Line 753: tempVar.setLastStopTime(new Date());
I was trying to consider how users will use this information in their workflows
and I think this will simplify things for them.
Consider the use case of wanting to make sure all VMs are run at least once per
month in order to install updates. In this case newly created VMs that have
not yet been started could be handled in the same way as the common case.
Line 754: VmDynamic vmDynamic = tempVar;
Line 755: DbFacade.getInstance().getVmDynamicDao().save(vmDynamic);
Line 756: getCompensationContext().snapshotNewEntity(vmDynamic);
Line 757: }
--
To view, visit http://gerrit.ovirt.org/22429
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f94a56e0c82246a932fc1800a2c9ef8c5205e13
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
