Alon Bar-Lev has posted comments on this change.
Change subject: packaging: remove 10-setup-database-reports.conf from package
......................................................................
Patch Set 1:
(3 comments)
....................................................
File packaging/ovirt-engine-reports-setup.py
Line 313: 'host': utils.getDbHostName(),
Line 314: 'port': utils.getDbPort(),
Line 315: 'username': REPORTS_DB_USER,
Line 316: 'password': utils.generatePassword(),
Line 317: 'engine_db': ENGINE_DB_DATABASE,
tabs
Line 318: }
Line 319:
Line 320: for file in (FILE_DATABASE_ENGINE_CONFIG,
FILE_DATABASE_DWH_CONFIG, FILE_DATABASE_REPORTS_CONFIG):
Line 321:
Line 340: if s is not None:
Line 341: db_dict[k] = s.strip('"')
Line 342: handler.close()
Line 343:
Line 344: elif file == FILE_DATABASE_ENGINE_CONFIG:
check this before this loop early at beginning of setup
Line 345: raise RuntimeError(
Line 346: 'Engine was not setup on this machine. '
Line 347: 'Please execute: \"engine-setup\" followed by '
Line 348: '\"ovirt-engine-dwh-setup\" '
....................................................
File packaging/ovirt-engine-reports.spec.in
Line 121
Line 122
Line 123
Line 124
Line 125
what about adding rm at %preun?
--
To view, visit http://gerrit.ovirt.org/22482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82c64c34993661cd8225b72f63326251422fd20a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
