Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Synchronize refresh.
......................................................................
Patch Set 4:
(2 comments)
Thanks for addressing my comments :)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java
Line 20: * Creates new {@link CommonModel} instance and sets up necessary
event listeners.
Line 21: * <p>
Line 22: * Should be called right after successful user authentication,
before redirecting the user to the main section.
Line 23: */
Line 24: public static void init(final EventBus eventBus) {
You're right, I missed that, sorry.
(We could bind CommonModelManager as singleton but that is indeed outside the
scope of this patch.)
Line 25: commonModel = CommonModel.newInstance();
Line 26:
Line 27: commonModel.getSelectedItemChangedEvent().addListener(new
IEventListener() {
Line 28: @Override
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/events/EventListModel.java
Line 235: {
Line 236: return;
Line 237: }
Line 238:
Line 239: if (!source.isEmpty()) {
OK, makes sense.
Line 240: //We received some new events, tell the active models to
update.
Line 241: RefreshActiveModelEvent.fire(this, false);
Line 242: }
Line 243: List<AuditLog> list = (List<AuditLog>) getItems();
--
To view, visit http://gerrit.ovirt.org/21057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa59712f8f74426b0ca6a132664167f42fb8d7b2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
