Juan Hernandez has posted comments on this change. Change subject: sdk: Add session support ......................................................................
Patch Set 1: (4 inline comments) Thanks for your revie Eoghan! I addressed most of your comments. .................................................... File src/ovirtsdk/infrastructure/proxy.py Line 29: From the point of view fo the CookieJar it looks like a urllib2 request and Done Line 64: return self._headers.get(header_name.lower(), defaul) Done Line 84: return result More pythonic but harder to read, at least for me. If you don't mind I am not changing it. Regarding the case take into account that self._header comes from a __init__ parameter, so it could contain uppercase strings as well. It is not probably the case, as the headers come from httplib which converts it to lowercase (at least the version I am using), but I think is it safer to avoid that assumption. Line 148: headers[key] = value More pythonic, simpler and easier to read. Thanks! -- To view, visit http://gerrit.ovirt.org/4044 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I098f7195777ee2c93b84b9ef461044b0fc697b10 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Eoghan Glynn <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
