Muli Salem has posted comments on this change. Change subject: core: Reloadable Config Values (1) ......................................................................
Patch Set 2: Looks good, however - I guess that in some of the files, you assign the result of Config.getValue to varaible, and not perform calls to Config.getValue as each call might reload the configuration. Am I correct here? In some files the values is assigned to a var, but this is only in cases where we wouldn't want it to change during the specific run (in commands for example). -- To view, visit http://gerrit.ovirt.org/3039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6213fb6e6a14c00acf7cc671405e943d908d898 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
