Omer Frenkel has posted comments on this change.
Change subject: engine: Gluster peer probe and status on same server
......................................................................
Patch Set 5:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
Line 78: private boolean vdsProxyFound;
Line 79: private boolean connectPoolSucceeded;
Line 80: private boolean glusterHostUuidFound, glusterPeerListSucceeded,
glusterPeerProbeSucceeded;
Line 81: private FenceStatusReturnValue fenceStatusReturnValue;
Line 82: private static int MAX_RETRIES_GLUSTER_PROBE_STATUS = 2;
why not make it configuration?
Line 83:
Line 84: public InitVdsOnUpCommand(HostStoragePoolParametersBase
parameters) {
Line 85: super(parameters);
Line 86: setVds(parameters.getVds());
....................................................
File packaging/dbscripts/vds_sp.sql
Line 815: BEGIN
Line 816: RETURN QUERY SELECT vds.*
Line 817: FROM vds
Line 818: WHERE (status = v_status) AND (vds_group_id = v_vds_group_id)
Line 819: ORDER BY vds.vds_id ASC;
not sure about this ordering because of other usages of this function
Line 820: END;
Line 821: RETURN;
Line 822: END; $procedure$
Line 823: LANGUAGE plpgsql;
--
To view, visit http://gerrit.ovirt.org/22448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1359a0c8f270b70a6afd3fd1490e5bb602d9b03f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
