Liron Ar has posted comments on this change. Change subject: core: GetAllDisksByVmIdQuery - improved performance and avoid NPE ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/dbscripts/create_views.sql Line 261: AS Line 262: SELECT all_disks_including_snapshots.*, vm_device.is_plugged, vm_device.is_readonly, vm_device.vm_id Line 263: FROM all_disks_including_snapshots Line 264: JOIN vm_device ON vm_device.device_id = all_disks_including_snapshots.image_group_id Line 265: WHERE ((vm_device.snapshot_id IS NULL AND all_disks_including_snapshots.active IS NOT FALSE) because for luns currently active returns as false (it's only defined for images) regardless, that code has just been moved in this patch..not modified. Line 266: OR vm_device.snapshot_id = all_disks_including_snapshots.vm_snapshot_id); Line 267: Line 268: Line 269: CREATE OR REPLACE VIEW storage_domains -- To view, visit http://gerrit.ovirt.org/22506 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91d12ee535563204b5d6aaeb64ec6a7c23ea1a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
