Juan Hernandez has posted comments on this change.
Change subject: restapi: Add Reboot support
......................................................................
Patch Set 16:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
Line 218: }
Line 219:
Line 220: private Integer getVmUserDelay(Action action) {
Line 221: if (action.isSetGracePeriod() &&
action.getGracePeriod().isSetExpiry()) {
Line 222: return (int) action.getGracePeriod().getExpiry();
If I understand correctly you are converting here a long to an integer. Isn't
there a risk of overflow?
Line 223: } else {
Line 224: return null;
Line 225: }
Line 226: }
--
To view, visit http://gerrit.ovirt.org/16194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a5007a1364392830e4112e57ec54a7025fee02
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Betak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
