Alon Bar-Lev has posted comments on this change.
Change subject: engine: Draft - Json-rpc integration
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 155:
Line 156: switch (getVds().getVdsType()) {
Line 157: case VDS:
Line 158:
installer.setFirewall(parameters.getOverrideFirewall());
Line 159:
installer.setTransportProtocol(parameters.getTransportProtocol());
did not see a change in VdsDeploy.
Line 160: break;
Line 161: case oVirtNode:
Line 162: if (parameters.getOverrideFirewall()) {
Line 163: log.warnFormat(
....................................................
File ovirt-engine.spec.in
Line 578
Line 579
Line 580
Line 581
Line 582
you probably need to add it here
....................................................
File pom.xml
Line 70: <cxf.version>2.2.7</cxf.version>
Line 71: <mina-core.version>2.0.1</mina-core.version>
Line 72: <sshd-core.version>0.7.0</sshd-core.version>
Line 73: <otopi.version>1.1.0</otopi.version>
Line 74: <ovirt-host-deploy.version>1.2.0-master</ovirt-host-deploy.version>
this is irrelevant^ as it is not used.
anyway it is temporary, you should use static hard coded string within code
without modifying the interface nor effect build.
Line 75: <vdsm-jsonrpc-java.version>1.0.0-master</vdsm-jsonrpc-java.version>
Line 76: <slf4j-jdk14.version>1.5.6</slf4j-jdk14.version>
Line 77: <gwt.version>2.5.1</gwt.version>
Line 78: <findbugs.version>2.5.2</findbugs.version>
--
To view, visit http://gerrit.ovirt.org/20926
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
