Moti Asayag has posted comments on this change. Change subject: core: [Fix] PCI limit in add balloon and sound ......................................................................
Patch Set 2: I wonder if the the repeated db access isn't abusive, since in most commands we approach the vm_devices table 3 times: for balloon, sound and virtioScsi. Perhaps the use of VmDeviceUtils should be replaced with a class that has a state of the vm devices which we can query about its devices, rather for accessing the db for each device query. Omer/Roy ? -- To view, visit http://gerrit.ovirt.org/22573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39fb7374426b67b64be2436b56197fcb6bfe3759 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
