Yair Zaslavsky has posted comments on this change. Change subject: engine: getUpServer method moved to new class ClusterUtils ......................................................................
Patch Set 3: I would prefer that you didn't submit this Please do not use PowerMock, we're trying to get read of it. If you insist on using Singletone , then in methods usings this util (I saw you have a base class for gluster commands) please extract method of protected GlusterUtils getClusterUtils() that will return the single instance. This way, you will be able to test with no PowerMock. -- To view, visit http://gerrit.ovirt.org/4040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20ec09d3fab39b8cd6d76e8c4c6c00f3ebb44b63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dhandapani Gopal <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
