Frank Kobzik has posted comments on this change.
Change subject: restapi: Allow enabling/disabling SSO
......................................................................
Patch Set 3:
(8 comments)
Thanks for valuable comments!
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 621: <xs:element ref="reported_device_types" minOccurs="0"/>
Line 622: <xs:element ref="ip_versions" minOccurs="0"/>
Line 623: <xs:element ref="snapshot_statuses" minOccurs="0"/>
Line 624: <xs:element ref="content_types" minOccurs="0" />
Line 625: <xs:element ref="hook_states" minOccurs="0" />
I don't really get this, please see my new version.
Line 626: <xs:element ref="stages" minOccurs="0" />
Line 627: </xs:sequence>
Line 628: </xs:extension>
Line 629: </xs:complexContent>
Line 2298: </xs:sequence>
Line 2299: <xs:attribute name="type" type="xs:string"/>
Line 2300: </xs:complexType>
Line 2301:
Line 2302: <!-- Single Sign-On Section -->
Done
Line 2303: <xs:complexType name="Sso">
Line 2304: <xs:sequence>
Line 2305: <xs:element name="methods" type="SsoMethods" minOccurs="1"
maxOccurs="1" />
Line 2306: </xs:sequence>
Line 2304: <xs:sequence>
Line 2305: <xs:element name="methods" type="SsoMethods" minOccurs="1"
maxOccurs="1" />
Line 2306: </xs:sequence>
Line 2307: </xs:complexType>
Line 2308:
Done
Line 2309: <xs:complexType name="SsoMethods">
Line 2310: <xs:sequence>
Line 2311: <xs:element name="method" type="SsoMethod" minOccurs="0"
maxOccurs="unbounded" />
Line 2312: </xs:sequence>
Line 2306: </xs:sequence>
Line 2307: </xs:complexType>
Line 2308:
Line 2309: <xs:complexType name="SsoMethods">
Line 2310: <xs:sequence>
Done
Line 2311: <xs:element name="method" type="SsoMethod" minOccurs="0"
maxOccurs="unbounded" />
Line 2312: </xs:sequence>
Line 2313: </xs:complexType>
Line 2314:
Line 2307: </xs:complexType>
Line 2308:
Line 2309: <xs:complexType name="SsoMethods">
Line 2310: <xs:sequence>
Line 2311: <xs:element name="method" type="SsoMethod" minOccurs="0"
maxOccurs="unbounded" />
Done
Line 2312: </xs:sequence>
Line 2313: </xs:complexType>
Line 2314:
Line 2315: <xs:simpleType name="SsoMethod">
Line 2315: <xs:simpleType name="SsoMethod">
Line 2316: <xs:restriction base="xs:string">
Line 2317: <xs:enumeration value="GUEST_AGENT"/>
Line 2318: </xs:restriction>
Line 2319: </xs:simpleType>
Done
Line 2320:
Line 2321: <xs:complexType name="HighAvailability">
Line 2322: <xs:sequence>
Line 2323: <xs:element name="enabled" type="xs:boolean" minOccurs="0"
maxOccurs="1"/>
Line 2526: <xs:element name="creation_time" type="xs:dateTime"
minOccurs="0"/>
Line 2527: <xs:element name="origin" type="xs:string" minOccurs="0"/>
Line 2528: <xs:element name="stateless" type="xs:boolean"
minOccurs="0"/>
Line 2529: <xs:element name="delete_protected" type="xs:boolean"
minOccurs="0"/>
Line 2530: <xs:element name="sso" type="Sso" minOccurs="0"
maxOccurs="1"/>
Done
Line 2531: <xs:element ref="console" minOccurs="0" maxOccurs="1"/>
Line 2532: <xs:element name="timezone" type="xs:string" minOccurs="0"
maxOccurs="1"/>
Line 2533: <xs:element ref="domain" minOccurs="0" maxOccurs="1"/>
Line 2534: <xs:element name="custom_properties"
type="CustomProperties" minOccurs="0"/>
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 75: vm.description: xs:string
Line 76: vm.comment: xs:string
Line 77: vm.stateless: xs:boolean
Line 78: vm.delete_protected: xs:boolean
Line 79: vm.sso.methods.method: --COLLECTION: {method: 'xs:string'}
Done
Line 80: vm.console.enabled: xs:boolean
Line 81: vm.cpu.topology.sockets: xs:int
Line 82: vm.placement_policy.affinity: xs:string
Line 83: vm.placement_policy.host.id|name: xs:string
--
To view, visit http://gerrit.ovirt.org/21911
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I25bf94646ea89684152e48f25ad604db6e59e86c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
