Allon Mureinik has posted comments on this change.
Change subject: core, engine: Prevent snapshot in ppc64
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 150: }
Line 151:
Line 152: private MemoryImageBuilder createMemoryImageBuilder() {
Line 153: boolean archSupportSnapshot =
isSnapshotSupportedByArchitecture(getVm().getClusterArch(),
getVm().getVdsGroupCompatibilityVersion());
Line 154: if
(!FeatureSupported.memorySnapshot(getVm().getVdsGroupCompatibilityVersion()) ||
archSupportSnapshot) {
Seems you are correct.
Line 155: return new NullableMemoryImageBuilder();
Line 156: }
Line 157:
Line 158: if (getParameters().getSnapshotType() ==
SnapshotType.STATELESS) {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 165: /**
Line 166: * Check if architecture supports snapshot
Line 167: * @return
Line 168: */
Line 169: public boolean isSnapshotSupportedByArchitecture
(ArchitectureType architecture, Version compatibilityVersion) {
+1.
Line 170: boolean supported = false;
Line 171: if (architecture != ArchitectureType.undefined) {
Line 172: supported =
ArchStrategyFactory.getStrategy(architecture).run(new
IsSnapshotSupported(compatibilityVersion)).returnValue();
Line 173: }
Line 167: * @return
Line 168: */
Line 169: public boolean isSnapshotSupportedByArchitecture
(ArchitectureType architecture, Version compatibilityVersion) {
Line 170: boolean supported = false;
Line 171: if (architecture != ArchitectureType.undefined) {
IMHO, the default should be the opposite.
Up until now, we always assumed snapshots are supported, and had a specific
issue with PPC64.
I don't want to disable this ability across the board, and start adding each
and every architecture I can imagine just to get snapshots support.
Line 172: supported =
ArchStrategyFactory.getStrategy(architecture).run(new
IsSnapshotSupported(compatibilityVersion)).returnValue();
Line 173: }
Line 174:
Line 175: return supported;
--
To view, visit http://gerrit.ovirt.org/21657
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f201b63ddf441a9bc76a37fda33f54fa766d937
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
