Alissa Bonas has uploaded a new change for review. Change subject: ui: rename members to start with lowercase in ListModel. ......................................................................
ui: rename members to start with lowercase in ListModel. Fix all places which use those members as well. Change-Id: Ie2005b745e74796704bd4b94eb1c384e2e93e72c Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 3 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/22624/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java index e08b8c4..ae900ab 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java @@ -587,7 +587,7 @@ { super.eventRaised(ev, sender, args); - if (ev.matchesDefinition(SelectedItemsChangedEventDefinition) && sender == getTagList()) + if (ev.matchesDefinition(selectedItemsChangedEventDefinition) && sender == getTagList()) { tagListModel_SelectedItemsChanged(sender, args); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java index 3239d48..3d1012e 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java @@ -29,7 +29,7 @@ privateSelectedItemChangedEvent = value; } - public static EventDefinition SelectedItemsChangedEventDefinition; + public static EventDefinition selectedItemsChangedEventDefinition; private Event privateSelectedItemsChangedEvent; public Event getSelectedItemsChangedEvent() @@ -42,7 +42,7 @@ privateSelectedItemsChangedEvent = value; } - public static EventDefinition ItemsChangedEventDefinition; + public static EventDefinition itemsChangedEventDefinition; private Event privateItemsChangedEvent; public Event getItemsChangedEvent() @@ -145,15 +145,15 @@ static { selectedItemChangedEventDefinition = new EventDefinition("SelectedItemChanged", ListModel.class); //$NON-NLS-1$ - SelectedItemsChangedEventDefinition = new EventDefinition("SelectedItemsChanged", ListModel.class); //$NON-NLS-1$ - ItemsChangedEventDefinition = new EventDefinition("ItemsChanged", ListModel.class); //$NON-NLS-1$ + selectedItemsChangedEventDefinition = new EventDefinition("SelectedItemsChanged", ListModel.class); //$NON-NLS-1$ + itemsChangedEventDefinition = new EventDefinition("ItemsChanged", ListModel.class); //$NON-NLS-1$ } public ListModel() { setSelectedItemChangedEvent(new Event(selectedItemChangedEventDefinition)); - setSelectedItemsChangedEvent(new Event(SelectedItemsChangedEventDefinition)); - setItemsChangedEvent(new Event(ItemsChangedEventDefinition)); + setSelectedItemsChangedEvent(new Event(selectedItemsChangedEventDefinition)); + setItemsChangedEvent(new Event(itemsChangedEventDefinition)); } protected void onSelectedItemChanging(T newValue, T oldValue) diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java index 929cc0d..3675086 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java @@ -1325,23 +1325,23 @@ super.eventRaised(ev, sender, args); UnitVmModel model = (UnitVmModel) getWindow(); - if (ev.matchesDefinition(ItemsChangedEventDefinition) && sender == model.getDataCenterWithClustersList()) + if (ev.matchesDefinition(itemsChangedEventDefinition) && sender == model.getDataCenterWithClustersList()) { updateDataCenterWithCluster(); } - else if (ev.matchesDefinition(ItemsChangedEventDefinition) && sender == model.getDefaultHost()) + else if (ev.matchesDefinition(itemsChangedEventDefinition) && sender == model.getDefaultHost()) { vmModel_DefaultHost_ItemsChanged(); } - else if (ev.matchesDefinition(ItemsChangedEventDefinition) && sender == model.getDisplayProtocol()) + else if (ev.matchesDefinition(itemsChangedEventDefinition) && sender == model.getDisplayProtocol()) { vmModel_DisplayProtocol_ItemsChanged(); } - else if (ev.matchesDefinition(ItemsChangedEventDefinition) && sender == model.getPriority()) + else if (ev.matchesDefinition(itemsChangedEventDefinition) && sender == model.getPriority()) { vmModel_Priority_ItemsChanged(); } - else if (ev.matchesDefinition(ItemsChangedEventDefinition) && sender == model.getTimeZone()) + else if (ev.matchesDefinition(itemsChangedEventDefinition) && sender == model.getTimeZone()) { vmModel_TimeZone_ItemsChanged(); } -- To view, visit http://gerrit.ovirt.org/22624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2005b745e74796704bd4b94eb1c384e2e93e72c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
