Omer Frenkel has posted comments on this change.
Change subject: core: deleting template with shared volumes should fail
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java
Line 157: return checkNoDisksBasedOnTemplateDisks();
Line 158: }
Line 159:
Line 160: private boolean checkNoDisksBasedOnTemplateDisks() {
Line 161: List<String> disksInfo = null;
+1
Line 162: for (DiskImage diskImage : imageTemplates) {
Line 163: List<DiskImage> basedDisks =
getDiskImageDAO().getAllSnapshotsForParent(diskImage.getImageId());
Line 164: for (DiskImage basedDisk : basedDisks) {
Line 165: if (disksInfo == null) {
--
To view, visit http://gerrit.ovirt.org/22162
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If781238d7be4768b1086645c64b4ccf807dc6108
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
