Yedidyah Bar David has posted comments on this change. Change subject: core: Alert on log file opening failure ......................................................................
Patch Set 2: Verified-1 Alon - I can't figure out how logging works in otopi. Added some debug prints to help me. "Start of _setupLogger" is printed twice, and in the middle "Opened log file" is printed. This means that the second call to logger.setLevel(logging.WARNING) (in _setupLogger) overwrites the call to self._handler.setLevel(logging.DEBUG) in src/plugins/otopi/core/log.py, and we get only warning+ logs also on the log file. Even if I manage to make it work, that is - WARNING before opening the log file, DEBUG after that, not sure that's what we want. -- To view, visit http://gerrit.ovirt.org/22625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1da48cc50985a3d353964466f38babbbd42f4f3 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
