Alissa Bonas has posted comments on this change. Change subject: core: Findbugs exclussions in JBoss modules plugin ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File build-tools-root/jboss-modules-maven-plugin/exclude-filters.xml Line 2: Line 3: <!-- Don't check the code generated by Maven, as one of the classes has a Line 4: minor issue, see MPLUGIN-255: --> Line 5: <Match> Line 6: <Class name="org.ovirt.engine.build.HelpMojo"/> Usually we also add the exact bug code/pattern name to exclude, in order not to miss other warnings that might come up in the same class. However since this class is not part of ovirt code, IMHO it's not necessary in this case. Line 7: </Match> Line 8: -- To view, visit http://gerrit.ovirt.org/22659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76106b935e0e987db04d99e36f89adc536754021 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
