Arik Hadas has uploaded a new change for review. Change subject: core: remove redundant fetch of vm disks on run vm ......................................................................
core: remove redundant fetch of vm disks on run vm There is no need to fetch the VM disks from the DB after we start to create stateless images on run VM as stateless flow. We fetch them in order to update the VM which is local to the RunVmCommand instance with the stateless images. But it is not used later on in the execute phase of the command, and the end-action phase is invoked on a new instance of RunVmCommand anyway. Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/62/22662/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java index 9c72074..ffb5432 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java @@ -348,9 +348,6 @@ if (vdcReturnValue.getSucceeded()) { getReturnValue().getVdsmTaskIdList().addAll(vdcReturnValue.getInternalVdsmTaskIdList()); - // save RunVmParams so we'll know how to run - // the stateless VM in the endAction part. - VmHandler.updateDisksFromDb(getVm()); } else { if (areDisksLocked(vdcReturnValue)) { throw new VdcBLLException(VdcBllErrors.IRS_IMAGE_STATUS_ILLEGAL); -- To view, visit http://gerrit.ovirt.org/22662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39f761ce6ed9563dfc1473afd1e7d330bc95bb20 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
