Yedidyah Bar David has posted comments on this change.
Change subject: packaging: setup: List unreverted changes on cleanup
......................................................................
Patch Set 2:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 114: (
Line 115: 'The following lines were not found in {file} and
so '
Line 116: 'were not removed:\n{lines}'
Line 117: ).format(
Line 118: file=filename,
It works.
There is something else that does not work, don't remember details - perhaps
dialog.note or something like that.
We have lots of code that writes to debug newlines like this.
Line 119: lines='\n'.join(
Line 120: [
Line 121: '\t{line}'.format(line=line)
Line 122: for line in remove_unremoved
--
To view, visit http://gerrit.ovirt.org/22621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9555c6d6a2f1652edc1065f9c49154123e8accc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
