Allon Mureinik has posted comments on this change. Change subject: core: some NFS mount options cleanup and test ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (2 inline comments) Generally looks good, but see some inline comments. Note that the review was done on a "pure" java level - someone else will have to evaluate the correction of the fixes to the code itself. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidLinuxMountPoint.java Line 20: @Constraint(validatedBy = NfsMountPointConstraint.class) Since you renamed all the other occurences of LinuxMountPointXXX to NfsMountPointXXX, consider renaming this one too. .................................................... File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/validation/NFSMountPointConstraintTest.java Line 6: Minor: Note that if one of the assertions fail, the ones after it will not run - and thus. it may take several fix-compile-run cycles to fix an issue. Consider using @Theory, @Parameterized or just separate @Test methods instead. -- To view, visit http://gerrit.ovirt.org/4091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b255acd5e1b7571509a35bc24b0ccccc58472d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
