Cheryn Tan has posted comments on this change.
Change subject: core: CDA to block disk alignment scan on file SDs
......................................................................
Patch Set 2:
(1 comment)
Just a minor nitpick about capital letters.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 1075: QOS_CPU_SHARES_OUT_OF_RANGE=Cannot set the cpu shares to the
requested value. It has to be between 0 and 262144.
Line 1076:
Line 1077: # Alignment scan
Line 1078: ERROR_CANNOT_RUN_ALIGNMENT_SCAN_VM_IS_RUNNING=Cannot ${action}
${type}. Alignment scan of a disk attached to a running VM is only supported
with RAW virtual disks.
Line 1079: ACTION_TYPE_FAILED_ALIGNMENT_SCAN_STORAGE_TYPE=Cannot ${action}
${type}. Alignment scan is only supported for disks located on block Storage
Domains.
Minor nitpick, "Storage Domains" does not need to be in capital letters, please
change to "storage domains".
Line 1080:
Line 1081: SCHEDULING_ALL_HOSTS_FILTERED_OUT=Cannot ${action} ${type}. There is
no host that satisfies current scheduling constraints. See bellow for details:
Line 1082: SCHEDULING_HOST_FILTERED_REASON=The host ${hostName} did not satisfy
${filterType} filter ${filterName}.
Line 1083: VAR__FILTERTYPE__EXTERNAL=$filterType external
--
To view, visit http://gerrit.ovirt.org/22661
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7a9505ac16c9dd3cf14b584b8ec7e7292d68e98
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Cheryn Tan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
