Hello Daniel Erez,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/22697
to review the following change.
Change subject: webadmin: disable scan alignment for non-block SDs
......................................................................
webadmin: disable scan alignment for non-block SDs
VMs -> Disks sub-tab:
disable scan alignment action for non-block storage domains
(as it's applicable only for block domains).
Disks main-tab:
scan alignment will be blocked on canDoAction in a separate patch.
Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Bug-Url: https://bugzilla.redhat.com/1046031
Signed-off-by: Daniel Erez <[email protected]>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/22697/1
diff --git
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
index 95465d6..1957756 100644
---
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
+++
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
@@ -817,6 +817,12 @@
VmDiskListModel model = (VmDiskListModel) target;
StoragePool dataCenter = (StoragePool) returnValue;
+ if (!dataCenter.getStorageType().isBlockDomain()) {
+ // scan alignment is applicable only for block storage
domains
+ model.setIsScanAlignmentEnabled(false);
+ return;
+ }
+
Version minClusterVersion =
vm.getVdsGroupCompatibilityVersion();
Version minDcVersion = dataCenter.getcompatibility_version();
--
To view, visit http://gerrit.ovirt.org/22697
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f4150f72332fb071a90001e63858a5212a0db0a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
