Alissa Bonas has uploaded a new change for review. Change subject: ui: rename members to start with lowercase in BookmarkListModel ......................................................................
ui: rename members to start with lowercase in BookmarkListModel Solves findbugs warnings Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Signed-off-by: Alissa Bonas <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java 2 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/06/22706/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java index ae900ab..88b223d 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java @@ -591,7 +591,7 @@ { tagListModel_SelectedItemsChanged(sender, args); } - else if (ev.matchesDefinition(BookmarkListModel.NavigatedEventDefinition) && sender == getBookmarkList()) + else if (ev.matchesDefinition(BookmarkListModel.navigatedEventDefinition) && sender == getBookmarkList()) { bookmarkListModel_Navigated(sender, (BookmarkEventArgs) args); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java index 55fc6fe..9d448c1 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java @@ -48,9 +48,9 @@ private static final BookmarksComparator COMPARATOR = new BookmarksComparator(); - public static EventDefinition NavigatedEventDefinition; + public static EventDefinition navigatedEventDefinition; - public static EventDefinition SavedEventDefinition; + public static EventDefinition savedEventDefinition; private Event privateNavigatedEvent; @@ -127,14 +127,14 @@ static { - NavigatedEventDefinition = new EventDefinition("Navigated", BookmarkListModel.class); //$NON-NLS-1$ - SavedEventDefinition = new EventDefinition("Saved", BookmarkListModel.class); //$NON-NLS-1$ + navigatedEventDefinition = new EventDefinition("Navigated", BookmarkListModel.class); //$NON-NLS-1$ + savedEventDefinition = new EventDefinition("Saved", BookmarkListModel.class); //$NON-NLS-1$ } public BookmarkListModel() { - setNavigatedEvent(new Event(NavigatedEventDefinition)); - setItemSavedEvent(new Event(SavedEventDefinition)); + setNavigatedEvent(new Event(navigatedEventDefinition)); + setItemSavedEvent(new Event(savedEventDefinition)); setNewCommand(new UICommand("New", this)); //$NON-NLS-1$ setEditCommand(new UICommand("Edit", this)); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/22706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99677d2d9d6a8666d34326768bffc52622b1b9e2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
