Gilad Chaplik has posted comments on this change.
Change subject: engine: Enable runOnce to choose a vnc keymap.
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
minor comments,
+1 for FE
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 726: }
Line 727:
Line 728: @Override
Line 729: protected boolean canDoAction() {
Line 730:
remove file from patch
Line 731: VM vm = getVm();
Line 732:
Line 733: if (vm == null) {
Line 734: return
failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java
Line 127: } else {
Line 128: // if is not null it means runVM was launch from the run
once command, thus
Line 129: // the VM can run with keyboard layout type which is
different from its default display type
Line 130:
getVm().setVncKeyboardLayout(getParameters().getVncKeyboardLayout());
Line 131: }
i'd move this logic to initCreateVmParams() method.
Line 132: }
Line 133:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RunVmParams.java
Line 221:
Line 222: public void setCpuShares(int cpuShares) {
Line 223: this.cpuShares = cpuShares;
Line 224: }
Line 225:
remove file from patch
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
Line 329: cloudInitEnabledEditor = new
EntityModelCheckBoxEditor(Align.RIGHT);
Line 330: }
Line 331:
Line 332: void initListBoxEditors() {
Line 333: vncKeyboardLayoutEditor = new
ListModelListBoxEditor<String>(new VncKeyMapRenderer(messages));
nice !
Line 334: }
Line 335:
Line 336: void initRadioButtonEditors() {
Line 337: displayConsoleVncEditor = new
EntityModelRadioButtonEditor("1"); //$NON-NLS-1$
--
To view, visit http://gerrit.ovirt.org/22620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id908cbaca9f1b20b4b9868a87a8b21f318a493e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kobi Ianko <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
