Mike Kolesnik has posted comments on this change.
Change subject: engine: Retrieve host interfaces by label
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/InterfaceDaoTest.java
Line 328: @Test
Line 329: public void testGetAllInterfacesByLabelForCluster() {
Line 330: List<VdsNetworkInterface> interfaces =
dao.getAllInterfacesByLabelForCluster(CLUSTER_ID, LABEL);
Line 331: assertNotNull(interfaces);
Line 332: assertEquals(1, interfaces.size());
Why check for specific size?
It would make more sense to go over the returned list and see that the LABEL is
actually contained in the labels field of each interface.
Line 333: }
--
To view, visit http://gerrit.ovirt.org/22656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb3fa47f3c85d4d884a1f4cb4d1a7c04528eee9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
