Yedidyah Bar David has posted comments on this change. Change subject: packging: fixed remote install setup ......................................................................
Patch Set 2: (2 comments) Other questions/issues: I am pretty certain that backup will fail if owner is postgres (upgrade from 3.1) - need to check this I do not understand why in some parts we allow setting db_dict['host'] to a different value, also added a comment in the code in one place We updateDbOwner by parsing pg_dump output. Won't it take, for a large db, lots of time on dwh, unnecessarily? Perhaps try with '-s' .................................................... File packaging/legacy-setup/ovirt-engine-dwh-setup.py Line 232: default=userdefault, Line 233: ) Line 234: Line 235: userInput = getpass.getpass( Line 236: 'Password for the remote DB user: ' changed to call getpass directly - there is no need to read it twice, we check it immediately Line 237: ) Line 238: Line 239: return (dbuser, userInput) Line 240: Line 364: output, rc = utils.runPostgresSuQuery(sql_query) Line 365: return '1' in output Line 366: Line 367: def isOvirtEngineInstalled(): Line 368: return os.path.exists(os.path.join(OVIRT_SETUP_POST_INSTALL_CONFIG)) That's what we currently check on engine-setup to know if 3.3 was setup. Can reports 3.3 work with engine 3.2? Line 369: Line 370: def main(options): Line 371: ''' Line 372: main -- To view, visit http://gerrit.ovirt.org/22701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic315856f91c60f240c6830fb90e5b259774e9745 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
