Mike Kolesnik has posted comments on this change.

Change subject: webadmin: Add ability to set the "force" label
......................................................................


Patch Set 1:

(4 comments)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/RemoveConfirmationPopupView.java
Line 139:                 }
Line 140:             }
Line 141:         });
Line 142: 
Line 143:         force.setLabel(object.getForceLabel());
Done
Line 144:         force.asCheckBox().setValue((Boolean) 
object.getForce().getEntity());
Line 145:         // Bind "Force.Label"
Line 146:         object.getPropertyChangedEvent().addListener(new 
IEventListener() {
Line 147:             @Override


Line 140:             }
Line 141:         });
Line 142: 
Line 143:         force.setLabel(object.getForceLabel());
Line 144:         force.asCheckBox().setValue((Boolean) 
object.getForce().getEntity());
By default the entity is false, so I don't know where you get your information 
from but it's not true.
Line 145:         // Bind "Force.Label"
Line 146:         object.getPropertyChangedEvent().addListener(new 
IEventListener() {
Line 147:             @Override
Line 148:             public void eventRaised(Event ev, Object sender, 
EventArgs args) {


....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java
Line 74: 
Line 75:         for (Object a : sourceListModel.getSelectedItems())
Line 76:         {
Line 77:             Network network = (Network) a;
Line 78:             if (network.isExternal()) {
Done
Line 79:                 pb.add(new RemoveNetworkParameters(network.getId(), 
getForce().getIsSelected()));
Line 80:             } else {
Line 81:                 pb.add(new RemoveNetworkParameters(network.getId()));
Line 82:             }


Line 75:         for (Object a : sourceListModel.getSelectedItems())
Line 76:         {
Line 77:             Network network = (Network) a;
Line 78:             if (network.isExternal()) {
Line 79:                 pb.add(new RemoveNetworkParameters(network.getId(), 
getForce().getIsSelected()));
Done
Line 80:             } else {
Line 81:                 pb.add(new RemoveNetworkParameters(network.getId()));
Line 82:             }
Line 83:         }


-- 
To view, visit http://gerrit.ovirt.org/22614
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If200c35cf36cf6f0fd7aa3d8ad0b0b59ce3ac1f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to