Omer Frenkel has submitted this change and it was merged. Change subject: core: fix NPE for removing non existing template ......................................................................
core: fix NPE for removing non existing template The locking message assume the template being removed exist in the DB, therefore NPE can be thrown there. Added a null check and in case the template is null, we won't try to lock the template (that is ok since the can-do-action phase is going to fail anyway). Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Signed-off-by: Omer Frenkel <[email protected]> Signed-off-by: Arik Hadas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/14712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id3eeb1d34d4e6320961ee8b360715b29003f1a68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
